linux-kernel - Re: [PATCH 1/1] mfd: menelaus: Use module_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140529120202.GL1954@lee--X1>
Date:	Thu, 29 May 2014 13:02:02 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mfd: menelaus: Use module_i2c_driver

> module_i2c_driver simplifies the code by eliminating
> boilerplate code.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  drivers/mfd/menelaus.c |   23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index ad25bfa3fb02..5e2667afe2bc 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -1287,29 +1287,8 @@ static struct i2c_driver menelaus_i2c_driver = {
>  	.id_table	= menelaus_id,
>  };
>  
> -static int __init menelaus_init(void)
> -{
> -	int res;
> -
> -	res = i2c_add_driver(&menelaus_i2c_driver);
> -	if (res < 0) {
> -		pr_err(DRIVER_NAME ": driver registration failed\n");
> -		return res;
> -	}
> -
> -	return 0;
> -}
> -
> -static void __exit menelaus_exit(void)
> -{
> -	i2c_del_driver(&menelaus_i2c_driver);
> -
> -	/* FIXME: Shutdown menelaus parts that can be shut down */
> -}
> +module_i2c_driver(menelaus_i2c_driver);
>  
>  MODULE_AUTHOR("Texas Instruments, Inc. (and others)");
>  MODULE_DESCRIPTION("I2C interface for Menelaus.");
>  MODULE_LICENSE("GPL");
> -
> -module_init(menelaus_init);
> -module_exit(menelaus_exit);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/