linux-kernel - Re: [PATCH tty-next] serial: sirf: Fix compilation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4ypSdP-i35BaQaciPo-g=+8Z5-T2MV5zgDP98BMciGbGw@mail.gmail.com>
Date:	Thu, 29 May 2014 20:14:02 +0800
From:	Barry Song <baohua@...nel.org>
To:	Daniel Thompson <daniel.thompson@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, patches@...aro.org,
	linaro-kernel@...ts.linaro.org, Jiri Slaby <jslaby@...e.cz>,
	Qipan Li <Qipan.Li@....com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH tty-next] serial: sirf: Fix compilation failure

2014-05-29 18:13 GMT+08:00 Daniel Thompson <daniel.thompson@...aro.org>:
> After 07d410e0) serial: sirf: fix spinlock deadlock issue it is no longer
> possiblet to compile this driver. The rename of one of the spinlocks is
> faulty. After looking at the original patch I believe this is the correct
> fix.
>
> Compile tested using ARM's multi_v7_defconfig
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.cz>
> Cc: Barry Song <baohua@...nel.org>
> Cc: Qipan Li <Qipan.Li@....com>
> Cc: linux-serial@...r.kernel.org
> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>

Qipan prepared a same patch to fix this. since you have sent,

Acked-by: Barry Song <baohua@...nel.org>


> ---
>
> Notes:
>     Sorry to resend within a few minutes. Patch is identical to parent but the
>     subject line has been corrected. The original 'v6' was just utterly
>     wrong! This patch is a not-previously-shared patch to fix a build
>     regression that appears in tty-next.
>
>  drivers/tty/serial/sirfsoc_uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c
> index 236f892..1f2be48 100644
> --- a/drivers/tty/serial/sirfsoc_uart.c
> +++ b/drivers/tty/serial/sirfsoc_uart.c
> @@ -704,7 +704,7 @@ static void sirfsoc_uart_rx_dma_complete_tl(unsigned long param)
>         struct sirfsoc_int_en *uint_en = &sirfport->uart_reg->uart_int_en;
>         unsigned long flags;
>         struct dma_tx_state tx_state;
> -       spin_lock_irqsave(&port->rx_lock, flags);
> +       spin_lock_irqsave(&port->lock, flags);
>         while (DMA_COMPLETE == dmaengine_tx_status(sirfport->rx_dma_chan,
>                         sirfport->rx_dma_items[sirfport->rx_completed].cookie, &tx_state)) {
>                 sirfsoc_uart_insert_rx_buf_to_tty(sirfport,
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/