linux-kernel - Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaR0E_fnFZaX7zYmxtLjEuRKr_XW7B8HavpkkjArmy35A@mail.gmail.com>
Date:	Thu, 29 May 2014 15:44:59 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	eric.ernst@...ux.intel.com,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Gross <mark.gross@...el.com>,
	"Holmberg, Hans" <hans.holmberg@...el.com>
Subject: Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

On Tue, May 27, 2014 at 9:26 PM,  <eric.ernst@...ux.intel.com> wrote:

> From: Eric Ernst <eric.ernst@...ux.intel.com>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode.  When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst <eric.ernst@...ux.intel.com>

Can I get some ACK from the author's of this driver on Eric's patch?

Eric, you *are* aware of what the gpio_lock_as_irq() and
gpio_unlock_as_irq() in the .irq_request_resources are doing
right? Is this patch just some extra safety measure?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/