linux-kernel - Re: [PATCH v2 04/05] staging: board: Initial board staging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANqRtoQDQLsWOyRSbQmtbmJc_qO=5X3ZMK12ZuwZ-FSR1iWCog@mail.gmail.com>
Date:	Thu, 29 May 2014 22:53:57 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	devel <devel@...verdev.osuosl.org>,
	SH-Linux <linux-sh@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	"Simon Horman [Horms]" <horms@...ge.net.au>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v2 04/05] staging: board: Initial board staging support

On Thu, May 29, 2014 at 10:27 PM, Magnus Damm <magnus.damm@...il.com> wrote:
> Hi Dan,
>
> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> <dan.carpenter@...cle.com> wrote:
>> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
>>> --- /dev/null
>>> +++ work/drivers/staging/board/Kconfig        2014-05-29 21:40:41.000000000 +0900
>>> @@ -0,0 +1,7 @@
>>> +config STAGING_BOARD
>>> +     boolean "Staging Board Support"
>>> +     help
>>> +       Select to enable per-board staging support code.
>>> +
>>> +       If in doubt, say N here.
>>> +
>>
>> Actually, you're probably going to need to add a bunch of dependencies
>> here or it will break "make randconfig" right away.  Sorry that I forgot
>> about this in the first review.
>
> Good point, thanks for checking. I will have a look at this and add
> dependencies to make sure it builds on a wide range of platforms.

To begin with, this hunk fixes the i386_defconfig + staging board build.

--- 0011/drivers/staging/board/Kconfig
+++ work/drivers/staging/board/Kconfig    2014-05-29 22:32:39.000000000 +0900
@@ -1,5 +1,6 @@
 config STAGING_BOARD
     boolean "Staging Board Support"
+    depends on OF && OF_ADDRESS
     help
       Select to enable per-board staging support code.

Actually, there are not many dependencies - I believe the OF bits is about it.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/