linux-kernel - Re: [PATCH V2 2/3] lib/debugobjects.c: add pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140529155116.GB31286@thin>
Date:	Thu, 29 May 2014 08:51:16 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH V2 2/3] lib/debugobjects.c: add pr_fmt to logging

On Thu, May 29, 2014 at 09:24:08AM +0200, Fabian Frederick wrote:
> Add ODEBUG: prefix to pr_fmt
> 
> Cc: Josh Triplett <josh@...htriplett.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  lib/debugobjects.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index ea4c737..b628247 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -7,6 +7,9 @@
>   *
>   * For licencing details see kernel-base/COPYING
>   */
> +
> +#define pr_fmt(fmt) "ODEBUG: " fmt
> +
>  #include <linux/debugobjects.h>
>  #include <linux/interrupt.h>
>  #include <linux/sched.h>
> @@ -218,7 +221,7 @@ static void debug_objects_oom(void)
>  	unsigned long flags;
>  	int i;
>  
> -	pr_warn("ODEBUG: Out of memory. ODEBUG disabled\n");
> +	pr_warn("Out of memory. ODEBUG disabled\n");
>  
>  	for (i = 0; i < ODEBUG_HASH_SIZE; i++, db++) {
>  		raw_spin_lock_irqsave(&db->lock, flags);
> @@ -292,9 +295,9 @@ static void debug_object_is_on_stack(void *addr, int onstack)
>  
>  	limit++;
>  	if (is_on_stack)
> -		pr_warn("ODEBUG: object is on stack, but not annotated\n");
> +		pr_warn("object is on stack, but not annotated\n");
>  	else
> -		pr_warn("ODEBUG: object is not on stack, but annotated\n");
> +		pr_warn("object is not on stack, but annotated\n");
>  	WARN_ON(1);
>  }
>  
> @@ -983,7 +986,7 @@ static void __init debug_objects_selftest(void)
>  	if (check_results(&obj, ODEBUG_STATE_NONE, ++fixups, ++warnings))
>  		goto out;
>  #endif
> -	pr_info("ODEBUG: selftest passed\n");
> +	pr_info("selftest passed\n");
>  
>  out:
>  	debug_objects_fixups = oldfixups;
> @@ -1088,7 +1091,7 @@ void __init debug_objects_mem_init(void)
>  		debug_objects_enabled = 0;
>  		if (obj_cache)
>  			kmem_cache_destroy(obj_cache);
> -		pr_warn("ODEBUG: out of memory.\n");
> +		pr_warn("out of memory.\n");
>  	} else
>  		debug_objects_selftest();
>  }
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/