linux-kernel - Re: [PATCH] mrf24j40: add managed API's provided by device layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5387723D.9020009@cogentembedded.com>
Date:	Thu, 29 May 2014 21:45:33 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Varka Bhadram <varkabhadram@...il.com>, alan@...nal11.us
CC:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	alex.aing@...il.com, Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH] mrf24j40: add managed API's provided by device layer

Hello.

On 05/29/2014 08:17 AM, Varka Bhadram wrote:

> This patch adds the managed APIs to the deriver code. By using this we need
> not to worry about freeing the memory and irq numbers.

> Thanks and Regards,
> Varka Bhadram

    This is not desirable thing in the patch changelog, maintainer will have 
to edit it out...

> Signed-off-by: Varka Bhadram <varkab@...c.in>
> ---
>   drivers/net/ieee802154/mrf24j40.c |   22 ++++++++++------------
>   1 file changed, 10 insertions(+), 12 deletions(-)

> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 78a6552..729ec0f 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -618,10 +618,11 @@ static int mrf24j40_probe(struct spi_device *spi)
>
>   	printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
>
> -	devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
> +	devrec = devm_kzalloc(spi->dev,
> +			sizeof(struct mrf24j40), GFP_KERNEL);

    Continuation line should start under the next character after ( on the 
previous line, according to the networking coding style.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/