linux-kernel - Re: [PATCH v4 2/3] mfd: intel_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53881097.6060506@linux.intel.com>
Date:	Fri, 30 May 2014 13:01:11 +0800
From:	"Zhu, Lejun" <lejun.zhu@...ux.intel.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	broonie@...nel.org, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org, jacob.jun.pan@...ux.intel.com,
	bin.yang@...el.com
Subject: Re: [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support



On 5/29/2014 7:49 PM, Lee Jones wrote:
> On Thu, 29 May 2014, Zhu, Lejun wrote:
> 
>> This patch provides chip-specific support for Crystal Cove. Crystal
>> Cove is the PMIC in Baytrail-T platform.
(...)
>> +enum crystal_cove_irq {
>> +	PWRSRC_IRQ = 0,
>> +	THRM_IRQ,
>> +	BCU_IRQ,
>> +	ADC_IRQ,
>> +	CHGR_IRQ,
>> +	GPIO_IRQ,
>> +	VHDMIOCP_IRQ
>> +};
> 
> I can't help thinking that these should be nice clear #defines
> 
> #define CRYSTAL_COVE_IRQ_PWSRC 		0
> ...
> #define CRYSTAL_COVE_IRQ_VHDMIOCP	6
> 

Sure. I'll fix it.

Best Regards
Lejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/