linux-kernel - Re: [PATCH v4] openrisc: irq: use irqchip framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5388669A.2090807@southpole.se>
Date:	Fri, 30 May 2014 13:08:10 +0200
From:	Jonas Bonn <jonas@...thpole.se>
To:	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
CC:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux <linux@...ts.openrisc.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4] openrisc: irq: use irqchip framework

On 05/29/2014 10:28 PM, Stefan Kristiansson wrote:
> On Tue, May 27, 2014 at 08:47:36AM +0200, Jonas Bonn wrote:
>> On 05/26/2014 10:52 PM, Geert Uytterhoeven wrote:
>>> CC devicetree for the bindings
>>>
>>> On Mon, May 26, 2014 at 10:31 PM, Stefan Kristiansson
>>> <stefan.kristiansson@...nalahti.fi> wrote:
>>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt
>>>> @@ -0,0 +1,23 @@
>>>> +OpenRISC 1000 Programmable Interrupt Controller
>>>> +
>>>> +Required properties:
>>>> +
>>>> +- compatible : should be "opencores,or1k-pic-level" for variants with
>>>> +  level triggered interrupt lines, "opencores,or1k-pic-edge" for variants with
>>>> +  edge triggered interrupt lines or "opencores,or1200-pic" for machines
>>>> +  with the non-spec compliant or1200 type implementation.
>>>> +
>>>> +  "opencores,or1k-pic" is also provided as an alias to "opencores,or1200-pic",
>>>> +  but this is only for backwards compatibility.
>>
>> I still think this identifier needs to be versioned.  Use the same
>> version number as we have on the cpu identifier since the OR1200 PIC
>> hasn't changed since then; i.e. opencores,or1200-pic-rtlsvnXYZ.
>>
> 
> I can change that if you *really* insist on it...
> But I don't understand the purpose of the versioning here,
> there will never be any other or1200-pic version than the one that currently
> exists, so IMO "or1200" should be enough versioning information.

Famous last words... ;)

It has been insisted upon earlier by upstream; for example, when we
submitted the openrisc architecture.  Aside from that, I am not the one
who is going to be doing any insisting here.

That said, given that this is a soft core CPU and what that entails, I
do think it is probably a good idea to version this thing.

Hopefully you will get some sage advice from someone else here...
otherwise, you may do as you see fit.

Your patch is otherwise fine by me and your effort here is much appreciated!

Acked-by: Jonas Bonn <jonas@...thpole.se>

/Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/