linux-kernel - Re: [PATCH v5 3/5] misc: fuse: Add efuse driver for Tegra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 May 2014 14:36:18 +0300
From:	Peter De Schrijver <pdeschrijver@...dia.com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Russell King <linux@....linux.org.uk>,
	Thierry Reding <thierry.reding@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Linus Walleij" <linus.walleij@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 3/5] misc: fuse: Add efuse driver for Tegra

On Thu, May 29, 2014 at 09:04:33PM +0200, Stephen Warren wrote:
> On 05/28/2014 06:54 AM, Peter De Schrijver wrote:
> > Implement fuse driver for Tegra20, Tegra30, Tegra114 and Tegra124.
> 
> > diff --git a/Documentation/ABI/testing/sysfs-driver-tegra-fuse b/Documentation/ABI/testing/sysfs-driver-tegra-fuse
> 
> > +Description:	read-only access to the efuses on Tegra20, Tegra30, Tegra114
> > +		and Tegra124 SoC's from NVIDIA. The efuses contain write once
> > +		data programmed at the factory. The data is layed out in 32bit
> > +		words in LSB first formnat. The number of valid bits depends
> 
> s/formnat/format/
> 
> > +		on the word and the SoC. The mapping is as follows:
> > +
> > +		For Tegra20:
> > +		Word 0 - 1    : bit 0
> > +		Word 2        : unused
> > +		Word 3        : bits 0 - 31
> > +		Word 4        : bits 0 - 7
> 
> Do we really need these long tables that indicate which bits are used?
> As I mentioned before, when I asked for documentation of the format of
> these files, all I wanted was a brief not indicating that the data was
> binary, and that each bit potentially represents a fuse... Either we
> should leave it at that, or actually document what each bit represents,
> which would hopefully be a pointless duplication of the TRM.

Some fuses are OEM defined, so there is no way to document all fuses there.
Would you be ok with just dropping the tables then? So, the description would
become:

Description:    read-only access to the efuses on Tegra20, Tegra30, Tegra114
                and Tegra124 SoC's from NVIDIA. The efuses contain write once
                data programmed at the factory. The data is layed out in 32bit
                words in LSB first format. The number of valid bits depends
                on the word and the SoC.

Cheers,

Peter.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/