linux-kernel - Re: [PATCH] staging: nokia_h4: nokia_core.c: use usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 May 2014 14:30:23 +0200
From:	Pavel Machek <pavel@....cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Miguel Oliveira <cmroliv@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>, gulsah.1004@...il.com,
	Pali Rohár <pali.rohar@...il.com>,
	peter.p.waskiewicz.jr@...el.com, kristina.martsenko@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: nokia_h4: nokia_core.c: use usleep_range()
 instead of msleep()

Hi!

> >> Creating this patch for the Eudyptula Challenge.
> >> Replaced msleep() for a delay < 20ms with a usleep_range() between 10000us and 15000us.
> >> Also inserted a blank line after adeclaration.
> > 
> > So you are changing timings without testing. Plus, burning CPU power
> > instead of sleeping.
> > 
> > Seems you'll need another patch for the challenge :-).
> 
> I actually wonder if anybody is seriously working on this driver. My concern with the staging drivers has always been that we are quick with merging them when the work on getting them into upstream shape is actually hard. However reality is once they are in staging nobody is doing the work to clean them up and fix the issues.
>

There is active work on merging n900 changes. And no, it does not
progress as quickly as I'd like, but we'll get there. It is also
requirement for n900 FM radio receiving...

> Greg, instead of wasting our time with this, can we just remove this driver from staging.

Please don't.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/