linux-kernel - Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVrDB7Q+oZi_WJk07a7OF_VOJiOHxpYwRABymTKsPuMoA@mail.gmail.com>
Date:	Fri, 30 May 2014 16:28:55 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Manuel Schölling <manuel.schoelling@....de>
Cc:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Mark Brown <broonie@...aro.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Dave Airlie <airlied@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles

Hi Manuel,

On Fri, May 30, 2014 at 3:27 PM, Manuel Schölling
<manuel.schoelling@....de> wrote:
> Add a scrollback buffers for each VGA console. The benefit is that
> the scrollback history is not flushed when switching between consoles
> but is persistent.
> The buffers are allocated on demand when a new console is opened.

Thanks for your patch!

I see two issues with this feature:
  1. Before, the single (default 64 KiB) buffer was allocated at startup.
     Now you will allocate a buffer each time a new console is opened.
     Depending on memory fragmentation, this may fail.
  2. People with RAM-constrained systems may not like this.
     Can it be a config option?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/