linux-kernel - Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5388BA8D.3010707@infradead.org>
Date:	Fri, 30 May 2014 10:06:21 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Manuel Schölling <manuel.schoelling@....de>,
	plagnioj@...osoft.com
CC:	tomi.valkeinen@...com, geert@...ux-m68k.org, broonie@...aro.org,
	dh.herrmann@...il.com, airlied@...hat.com, mtosatti@...hat.com,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] console: Add persistent scrollback buffers for all VGA
 consoles

On 05/30/2014 06:27 AM, Manuel Schölling wrote:
> ---
>  drivers/video/console/Kconfig  |    6 +-
>  drivers/video/console/vgacon.c |  124 ++++++++++++++++++++++++----------------
>  2 files changed, 79 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fe1cd01..d7ec96c 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -38,14 +38,14 @@ config VGACON_SOFT_SCROLLBACK
>  	 RAM to allocate for this buffer.  If unsure, say 'N'.
>  
>  config VGACON_SOFT_SCROLLBACK_SIZE
> -       int "Scrollback Buffer Size (in KB)"
> +       int "Scrollback Buffer Size per console (in KB)"
>         depends on VGACON_SOFT_SCROLLBACK
>         range 1 1024
>         default "64"
>         help
>           Enter the amount of System RAM to allocate for the scrollback
> -	 buffer.  Each 64KB will give you approximately 16 80x25
> -	 screenfuls of scrollback buffer
> +	 buffer for each VGA console. Each 64KB will give you approximately
> +	 16 80x25 screenfuls of scrollback buffer.

Nitpick: CodingStyle says to indent help text 1 tab + 2 spaces.

>  
>  config MDA_CONSOLE
>  	depends on !M68K && !PARISC && ISA

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/