linux-kernel - Re: [PATCH] arcnet: remove check for CONFIG_SA1100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140530.172615.2243203796607511160.davem@davemloft.net>
Date:	Fri, 30 May 2014 17:26:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pebolle@...cali.nl
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arcnet: remove check for CONFIG_SA1100_CT6001

From: David Miller <davem@...emloft.net>
Date: Fri, 30 May 2014 17:21:09 -0700 (PDT)

> From: Paul Bolle <pebolle@...cali.nl>
> Date: Tue, 27 May 2014 21:53:44 +0200
> 
>> A check for CONFIG_SA1100_CT6001 was added in v2.6.11. But the related
>> Kconfig symbol was never added to the tree. Remove this check and do
>> some related cleaning up.
>> 
>> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> 
> Applied to net-next, thanks.

Reverted, you missed more references to BUS_ALIGN in com20020.c:

drivers/net/arcnet/com20020.c: In function ‘com20020_check’:
drivers/net/arcnet/com20020.c:120:22: error: ‘BUS_ALIGN’ undeclared (first use in this function)
drivers/net/arcnet/com20020.c:120:22: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/arcnet/com20020.c: In function ‘com20020_found’:
drivers/net/arcnet/com20020.c:182:35: error: ‘BUS_ALIGN’ undeclared (first use in this function)

For a driver that builds on x86, there is no excuse not to have at least
build tested this patch.