linux-kernel - Re: [PATCH] Staging: android: binder: Fix over-80-char lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGC3nLAKKGGwN8fTyoragp4YyqiHD16kocuWq-FDa3ENDNb5Fg@mail.gmail.com>
Date:	Sat, 31 May 2014 11:25:10 -0600
From:	Daniel Dressler <danieru.dressler@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	serban.constantinescu@....com, linux-kernel@...r.kernel.org,
	arve@...roid.com, John Stultz <john.stultz@...aro.org>,
	prtvar.b@...il.com
Subject: Re: [PATCH] Staging: android: binder: Fix over-80-char lines

Thank you Neil

I was not sure if space-based alignment was allowed so thank you for
demonstrating the change. It does make the code much easier to read.

Similar thank you for how to indent over-long function calls. I had
mis-understood the coding standard to mean overflow needed to be on
the far right margin. A single indent before the first argument looks
much nicer and consistent.

Thank you Dan

You are right! It does break the code. Thank you for finding that and
the name issue. I'll rewrite the patch on top of linux-next this time
with the proper style as Neil suggested. I think git send-email added
the danieru. I had tried fixing the name my git config and then git
amending but send-email continued adding the danieru address so I
assumed that it always took the current user's username. Now it sounds
like that was some metadata git did not redo upon amend.

Daniel

2014-05-31 0:51 GMT-06:00 Dan Carpenter <dan.carpenter@...cle.com>:
> What Neil said.
>
> On Fri, May 30, 2014 at 10:31:20PM -0600, Daniel Dressler wrote:
>> From: danieru <danieru.dressler@...il.com>
>
> This is wrong and we also get your name and email address from the
> email headers so leave this line out.
>
>>
>> Following Greg Kroah-Hartman's newbie guide to hacking
>> the linux kernel this patch addresses only coding style
>> issues.
>>
>> Binder still has many too-long lines but I'm worried
>> doing too much work in a single patch is unfair to the
>> reviewers. So this patch address 20% of the file's
>> issues.
>>
>> There is one change to take notice of: it merges two if
>> statement's conditionals together. Then it removes a
>> redundant else clause.
>
> Thanks for pointing this out, but the else statement wasn't redundant.
> Your change introduces a bug.
>
> Your patch doesn't apply.  You need to work against linux-next.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/