linux-kernel - Re: [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFo99gYJ_K9qEaHihtvaFT4Wv3ApUZMJmTK=nuqK+=sA2NaYsA@mail.gmail.com>
Date:	Sun, 1 Jun 2014 18:44:15 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	Network Development <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up
 uninitialized variables

Hi Sergei!

Okay, sorry. But you agree with what it is doing in general then?

In this case, I am sending a new patch...

Best regards
Rickard Strandqvist


2014-06-01 18:38 GMT+02:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> Hello.
>
>
> On 06/01/2014 04:49 PM, Rickard Strandqvist wrote:
>
>> There is a risk that the variable will be used without being initialized.
>
>
>> This was largely found by using a static code analysis program called
>> cppcheck.
>
>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>   drivers/net/wireless/rtlwifi/rtl8192de/phy.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c
>> b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c
>> index 3d1f0dd..66abaf6 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c
>> @@ -203,11 +203,11 @@ u32 rtl92d_phy_query_bb_reg(struct ieee80211_hw *hw,
>> u32 regaddr, u32 bitmask)
>>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>>         struct rtl_hal *rtlhal = rtl_hal(rtlpriv);
>>         u32 returnvalue, originalvalue, bitshift;
>> -       u8 dbi_direct;
>>
>>         RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, "regaddr(%#x),
>> bitmask(%#x)\n",
>>                  regaddr, bitmask);
>>         if (rtlhal->during_mac1init_radioa ||
>> rtlhal->during_mac0init_radiob) {
>> +               u8 dbi_direct = 0;
>
>
>    Empty line is needed here, after declarations, like above.
>
>
>>                 /* mac1 use phy0 read radio_b. */
>>                 /* mac0 use phy1 read radio_b. */
>>                 if (rtlhal->during_mac1init_radioa)
>
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/