linux-kernel - Re: [PATCH] driver/netfilter/nfnetlink: removed unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Jun 2014 11:55:59 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Robin Schroer <sulamiification@...il.com>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	netfilter@...r.kernel.org, coreteam@...filter.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver/netfilter/nfnetlink: removed unused variable

On Sat, May 31, 2014 at 1:06 PM, Robin Schroer
<sulamiification@...il.com> wrote:
> Removes the unused struct net *net = sock_net(skb->sk);
>
> Signed-off-by: Robin Schroer <sulamiification@...il.com>

Against which tree is that patch?
net-next.git still uses net in nfnetlink_rcv_batch() AFAICT.

---cut---
if (err < 0)
goto ack;

if (nc->call_batch) {
err = nc->call_batch(net->nfnl, skb, nlh,
    (const struct nlattr **)cda);
}

/* The lock was released to autoload some module, we
* have to abort and start from scratch using the
* original skb.
*/
---cut---

> ---
>  net/netfilter/nfnetlink.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> index c138b8f..5cc9db2 100644
> --- a/net/netfilter/nfnetlink.c
> +++ b/net/netfilter/nfnetlink.c
> @@ -226,7 +226,6 @@ static void nfnetlink_rcv_batch(struct sk_buff *skb, struct nlmsghdr *nlh,
>                                 u_int16_t subsys_id)
>  {
>         struct sk_buff *nskb, *oskb = skb;
> -       struct net *net = sock_net(skb->sk);
>         const struct nfnetlink_subsystem *ss;
>         const struct nfnl_callback *nc;
>         bool success = true, done = false;
> --
> 1.9.3
>
>
> --
>
> Robin Schroer
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/