linux-kernel - Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140602125055.GE31751@sirena.org.uk>
Date:	Mon, 2 Jun 2014 13:50:55 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tim Kryger <tim.kryger@...il.com>
Cc:	Jingoo Han <jg1.han@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, Matt Porter <mporter@...aro.org>,
	Tim Kryger <tim.kryger@...aro.org>
Subject: Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote:

> The probe method of this driver, on the other hand, performs several
> allocations and the error messages you intend to remove conveniently
> pinpoint which one failed.  While the offsets in the trace could be
> used to derive the same information, I am skeptical that is enough to
> justify removing the messages.

On the other hand how likely is anyone to care which particular
allocation triggered the OOM?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)