linux-kernel - Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140602131443.GA3983@gmail.com>
Date:	Mon, 2 Jun 2014 14:14:45 +0100
From:	John Church <sleeveroller@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, lisa@...apiadmin.com,
	bergwolf@...il.com, andreas.dilger@...el.com,
	oleg.drokin@...el.com, doug.s.oucharek@...el.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warnings for undeclared
 symbols

On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote:
> 
> Why not just make them static?  They don't seem to be used outside of
> that file.  What am I missing?
> 

Given a 50/50 choice I based my decision on the surrounding functions which were mostly defined in the header file.

I should have done a little more invstigation which would have led me to the opposite conclusion.

I will redo them as static and resumbit.

Thanks for your help Dan.

Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/