linux-kernel - Re: [PATCH 1/3] replace PAGECACHE_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <538CAA13.2080708@intel.com>
Date:	Mon, 02 Jun 2014 09:45:07 -0700
From:	Dave Hansen <dave.hansen@...el.com>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
CC:	akpm@...ux-foundation.org, koct9i@...il.com,
	fengguang.wu@...el.com, acme@...hat.com, bp@...en8.de,
	kirill@...temov.name, hannes@...xchg.org, rusty@...tcorp.com.au,
	davem@...emloft.net, andres@...quadrant.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/3] replace PAGECACHE_TAG_* definition with enumeration

On 06/02/2014 09:37 AM, Naoya Horiguchi wrote:
> On Mon, Jun 02, 2014 at 09:12:25AM -0700, Dave Hansen wrote:
>> > On 06/01/2014 10:24 PM, Naoya Horiguchi wrote:
>>> > > -#define PAGECACHE_TAG_DIRTY	0
>>> > > -#define PAGECACHE_TAG_WRITEBACK	1
>>> > > -#define PAGECACHE_TAG_TOWRITE	2
>>> > > +enum {
>>> > > +	PAGECACHE_TAG_DIRTY,
>>> > > +	PAGECACHE_TAG_WRITEBACK,
>>> > > +	PAGECACHE_TAG_TOWRITE,
>>> > > +	__NR_PAGECACHE_TAGS,
>>> > > +};
>> > 
>> > Doesn't this end up exposing kernel-internal values out to a userspace
>> > interface?  Wouldn't that lock these values in to the ABI?
> Yes, that would. I hope these PAGECACHE_TAG_* stuff is very basic
> things and will never change drastically in the future (only added),
> so it's unlikely to bother people about ABI breakage things.

OK, so if I'm writing a userspace program, which header do I include
pull these values in to my program?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/