linux-kernel - Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538CB805.8030303@kernel.org>
Date:	Mon, 02 Jun 2014 18:44:37 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Federico Di Pierro <nierro92@...il.com>,
	gregkh@...uxfoundation.org, jg1.han@...sung.com,
	sachin.kamat@...aro.org
CC:	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

On 02/06/14 18:05, Federico Di Pierro wrote:
> Hi!
> This is my latest task of the eudyptula challenge.
> Just a very small patch! It fixes 3 little coding style problems.
> I'm using linux-next.
Fair enough, but you need to spend a little time working
on the 'how' of your patch submission.
See Documentation/SubmittingPatches and repost the patch according
to those guidelines.

Also at a quick glance, unless I am very bored I'm unlikely to take
such a minor white space and bracket adjustment patch. If it were
part of a bigger series doing something more interesting I'd be
more interested.

If you want to approach this driver, then feel free but there are
many more major issues within it to be looked at such as ABI
compliance.  See Documentation/ABI/testing/sysfs-bus-iio and friends
and compare the driver with them.  Off the top of my head I can't
remember how bad this driver is but I doubt everything is well
documented.

Don't feel disheartened, as I would be happy to see more substantial
cleanup patches from you as part of the challenge or otherwise.

Good luck,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/