linux-kernel - Re: [PATCH] stmmac: add DMA initialization delay to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140602.111543.1026699389707378851.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 11:15:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Alexey.Brodkin@...opsys.com
Cc:	netdev@...r.kernel.org, hdegoede@...hat.com,
	peppe.cavallaro@...com, wens@...e.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	Vineet.Gupta1@...opsys.com
Subject: Re: [PATCH] stmmac: add DMA initialization delay to device tree

From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Date: Mon,  2 Jun 2014 18:53:55 +0400

> On some platforms existing 100 msecond delay is not enough for DMA block to
> recover after reset.
> For example MAC DMA waits for all PHY input clocks are present and depending
> on the board reset bit deassertion may take different amount of time.
> 
> Having this parameter easily configurable allows each board to have its own
> value, while all exisiting boards will continue to use current default value of
> 100 msec.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>

Is there an upper bound for this you can just use?

It taking too long and timing out is an error condition, so just
using a limit value of "100" or something should be perfectly fine.

I don't think it's reasonable to put every conceivable nuance into
the DT nodes.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/