linux-kernel - Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140602181658.GX22231@linux.vnet.ibm.com>
Date:	Mon, 2 Jun 2014 11:16:58 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Joe Perches <joe@...ches.com>
Cc:	josh@...htriplett.org, linux-kernel@...r.kernel.org,
	mingo@...nel.org, laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	dvhart@...ux.intel.com, fweisbec@...il.com, oleg@...hat.com,
	sbw@....edu
Subject: Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

On Mon, Jun 02, 2014 at 10:59:28AM -0700, Joe Perches wrote:
> On Mon, 2014-06-02 at 10:48 -0700, josh@...htriplett.org wrote:
> > On Mon, Jun 02, 2014 at 10:22:58AM -0700, Joe Perches wrote:
> > > On Mon, 2014-06-02 at 10:00 -0700, Paul E. McKenney wrote:
> > > > A ksummit-discuss email thread looked at the difficulty recruiting
> > > > and retaining reviewers.
> > > 
> > > []
> > > 
> > > > Paul Walmsley also noted the need for patch
> > > > submitters to know who the key reviewers are and suggested adding an
> > > > "R:" tag to the MAINTAINERS file to record this information on a
> > > > per-subsystem basis.
> > > 
> > > I'm not sure of the value of this.
> > > 
> > > Why not just mark the actual reviewers as maintainers?
> > 
> > As discussed in the kernel summit discussion, being a regular patch
> > reviewer isn't the same thing as being *the* maintainer.
> 
> I think it's not particularly important or valuable
> here to make that distinction.
> 
> What real difference does it make?

In the particular case of Josh, none, at least from my viewpoint.  He of
course might or might not want to take on additional maintainership
responsibility at this particular point in time, in which case, I would
be more than happy to have him as a designated maintainer.

But there have been people who have found serious issues in RCU patches
who I would not trust as full maintainers.  The ability to find defects
is valuable in and of itself, and should be recognized as such, even
when not accompanied by the rest of the maintainership package.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/