linux-kernel - Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1401736666.7323.25.camel@joe-AO725>
Date:	Mon, 02 Jun 2014 12:17:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	josh@...htriplett.org
Cc:	Steven Rostedt <rostedt@...dmis.org>, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	dhowells@...hat.com, edumazet@...gle.com, dvhart@...ux.intel.com,
	fweisbec@...il.com, oleg@...hat.com, sbw@....edu
Subject: Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

On Mon, 2014-06-02 at 12:09 -0700, josh@...htriplett.org wrote:
> On Mon, Jun 02, 2014 at 12:05:17PM -0700, Joe Perches wrote:
> > On Mon, 2014-06-02 at 11:55 -0700, josh@...htriplett.org wrote:
> > > this should go along with a change to
> > > get_maintainer.pl to add those folks to the CC list.
> > 
> > Something like this:
> 
> Yes, exactly.  Given an appropriate commit message,
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

That's the sort of patch where reviewing is
pretty useless.

What it needs is testing, not reviewing.

I tested it for all of 10 seconds.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/