linux-kernel - Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and some warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2014 12:23:16 -0700
From:	Thomas Wood <tommyandrena@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	marek.belisko@...il.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style
 errors and some warnings.



On 06/02/2014 03:30 AM, Dan Carpenter wrote:
> On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
>> Don't use spaces as tabs, and fix other style errors and warnings.
>>
>> Signed-off-by: Thomas Wood <tommyandrena@...il.com>
> 
> Too much in one patch.  Break it up into one type of fix per patch and
> send a series of patches.
> 
> [patch 1] use tabs
> [patch 2] fix braces style
> [patch 3] remove parens from return values
> [patch 4] reverse an if statement
> 
> patch 3 and 4 are small enough that you could get away with pushing them
> into a single "misc fixes" patch and we wouldn't have complained but the
> first two patches are very big.
> 
> regards,
> dan carpenter
> 
> 
Ah, thank you. I will do so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/