linux-kernel - Re: [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2014 12:39:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the
 only __initcall substitute

On Mon, 2014-06-02 at 19:12 +0200, Fabian Frederick wrote:
> This patch adds a link to init.h to find accurate initcall function
> to replace obsolete __initcall

maybe s/accurate/appropriate/

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4443,10 +4443,10 @@ sub process {
>  			     "$1 is obsolete, use k$3 instead\n" . $herecurr);
>  		}
>  
> -# check for __initcall(), use device_initcall() explicitly please
> +# check for __initcall(), use device_initcall() explicitly or more accurate function please
>  		if ($line =~ /^.\s*__initcall\s*\(/) {
>  			WARN("USE_DEVICE_INITCALL",
> -			     "please use device_initcall() instead of __initcall()\n" . $herecurr);
> +			     "please use device_initcall() or more accurate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
>  		}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/