linux-kernel - Re: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jun 2014 13:09:08 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Vlastimil Babka <vbabka@...e.cz>
cc:	Fabio Estevam <festevam@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Kevin Hilman <khilman@...aro.org>,
	Rik van Riel <riel@...hat.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Minchan Kim <minchan@...nel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Hugh Dickins <hughd@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Michal Nazarewicz <mina86@...a86.com>, linux-mm@...ck.org,
	Mel Gorman <mgorman@...e.de>, Olof Johansson <olof@...om.net>,
	Greg Thelen <gthelen@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Christoph Lameter <cl@...ux.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -mm] mm, compaction: properly signal and act upon lock
 and need_sched() contention - fix

On Mon, 2 Jun 2014, Vlastimil Babka wrote:

> compact_should_abort() returns true instead of false and vice versa
> due to changes between v1 and v2 of the patch. This makes both async
> and sync compaction abort with high probability, and has been reported
> to cause e.g. soft lockups on some ARM boards, or drivers calling
> dma_alloc_coherent() fail to probe with CMA enabled on different boards.
> 
> This patch fixes the return value to match comments and callers expecations.
> 
> Reported-and-tested-by: Kevin Hilman <khilman@...aro.org>
> Reported-and-tested-by: Shawn Guo <shawn.guo@...aro.org>
> Tested-by: Stephen Warren <swarren@...dia.com>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/