linux-kernel - Re: [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jun 2014 13:22:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org>,
	ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: ocfs2: dir.c:  Cleaning up uninitialized variables

On Sun,  1 Jun 2014 15:53:04 +0200 Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:

> There is a risk that the variable will be used without being initialized.

um, no there isn't.

> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -3738,7 +3738,7 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir,
>  	int credits, ret, i, num_used, did_quota = 0;
>  	u32 cpos, split_hash, insert_hash = hinfo->major_hash;
>  	u64 orig_leaves_start;
> -	int num_dx_leaves;
> +	int num_dx_leaves = 0;
>  	struct buffer_head **orig_dx_leaves = NULL;
>  	struct buffer_head **new_dx_leaves = NULL;
>  	struct ocfs2_alloc_context *data_ac = NULL, *meta_ac = NULL;

If ocfs2_dx_dir_kmalloc_leaves() returns non-zero, num_dx_leaves will
have been initialized.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/