[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140602213358.10062.55182@quantum>
Date: Mon, 02 Jun 2014 14:33:58 -0700
From: Mike Turquette <mturquette@...aro.org>
To: Heiko Stübner <heiko@...ech.de>,
"Alessandro Zummo" <a.zummo@...ertech.it>,
"Andrew Morton" <akpm@...ux-foundation.org>
Cc: "Pawel Moll" <pawel.moll@....com>,
"Mark Rutland" <mark.rutland@....com>,
"Stephen Warren" <swarren@...dotorg.org>,
"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
rtc-linux@...glegroups.com, "Rob Herring" <robh+dt@...nel.org>
Subject: Re: [PATCH] rtc: hym8563: add optional clock-output-names property
Quoting Heiko Stübner (2014-05-18 15:40:07)
> This enables the setting of a custom clock name for the clock provided by
> the hym8563 rtc.
>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
Annoying nitpick: would be nice to see the example updated to use
clock-output-names. But it's not a deal breaker.
Reviewed-by: Mike Turquette <mturquette@...aro.org>
Regards,
Mike
> ---
> Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt | 3 +++
> drivers/rtc/rtc-hym8563.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> index 31406fd..5c199ee 100644
> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> @@ -9,6 +9,9 @@ Required properties:
> - interrupts: rtc alarm/event interrupt
> - #clock-cells: the value should be 0
>
> +Optional properties:
> +- clock-output-names: From common clock binding
> +
> Example:
>
> hym8563: hym8563@51 {
> diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
> index e5f13c4..6442b5b 100644
> --- a/drivers/rtc/rtc-hym8563.c
> +++ b/drivers/rtc/rtc-hym8563.c
> @@ -418,6 +418,9 @@ static struct clk *hym8563_clkout_register_clk(struct hym8563 *hym8563)
> init.num_parents = 0;
> hym8563->clkout_hw.init = &init;
>
> + /* optional override of the clockname */
> + of_property_read_string(node, "clock-output-names", &init.name);
> +
> /* register the clock */
> clk = clk_register(&client->dev, &hym8563->clkout_hw);
>
> --
> 1.9.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists