linux-kernel - Re: 3.15 regression: wrong cgroup magic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140603012211.GE19855@htj.dyndns.org>
Date:	Mon, 2 Jun 2014 21:22:11 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Andy Lutomirski <luto@...capital.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jianyu Zhan <nasa4836@...il.com>
Subject: Re: 3.15 regression: wrong cgroup magic

On Tue, Jun 03, 2014 at 09:18:25AM +0800, Li Zefan wrote:
> > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312
> > Author: Tejun Heo <tj@...nel.org>
> > Date:   Tue Feb 11 11:52:49 2014 -0500
> > 
> >     cgroup: convert to kernfs
> > 
> > In particular, this piece:
> > 
> > -       sb->s_magic = CGROUP_SUPER_MAGIC;
> > 
> > The result is that cgroup shows up with the wrong magic number, so my
> > code goes "oh crap, cgroupfs isn't mounted" and fails.
> > 
> > I can change my code to hack around this, but I can imagine other
> > things getting tripped up.  Is there still time to fix this?
> > 
> 
> This should be fixed by "kernfs: move the last knowledge of sysfs out from kernfs".
> 
> It's in driver-core-next.
> 
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=26fc9cd200ec839e0b3095e05ae018f27314e7aa

Right, I was writing about the same patch with a nagging sense of
deja-vu.  I should have noticed that this must go through
driver-core-linus not -next.  Sorry about that.

Linus, can you please cherry-pick the commit?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/