linux-kernel - Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jun 2014 15:12:04 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	carlo@...one.org, Boris Brezillon <boris@...e-electrons.com>,
	lgirdwood@...il.com, lee.jones@...aro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kevin.z.m.zh@...il.com, sunny@...winnertech.com,
	shuge@...winnertech.com, zhuzhenhua@...winnertech.com
Subject: Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a
 local parent regulator

On Wed, May 28, 2014 at 07:50:51PM +0100, Mark Brown wrote:
> On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote:
> 
> >  		axp_vcore_reg: dcdc2 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_ddr_reg: dcdc3 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_rtc_reg: ldo1 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_analog_reg: ldo2 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_pll_reg: ldo3 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_hdmi_reg: ldo4 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> >  		axp_mic_reg: ldo5 {
> > +			vin-supply = <&axp_ipsout_reg>;
> 
> This is saying that every single regulator on the device is powered by a
> (presumably) single input called "vin".  This would certainly be an
> unusual package design...  As ever the name of the supply should follow
> the name of the pin on the device.

Not exactly. Each regulator has its own input pin, named
<regulator_name>in in the schematics, with the exception of LDO2 and
LDO4 that share the same pin.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)