linux-kernel - Re: [PATCH 06/13] perf tools: Cache dso data file descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140603134145.GD2864@krava.brq.redhat.com>
Date:	Tue, 3 Jun 2014 15:41:45 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	David Ahern <dsahern@...il.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Jean Pihet <jean.pihet@...aro.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 06/13] perf tools: Cache dso data file descriptor

On Tue, Jun 03, 2014 at 07:36:25AM -0600, David Ahern wrote:
> On 6/2/14, 3:18 PM, Jiri Olsa wrote:
> >We keep dsos data file descriptors open until their count reaches
> >the half of the current fd open limit (RLIMIT_NOFILE). In this case
> >we close file descriptor of the first opened dso object.
> >
> >We've got overall speedup (24% for my workload) of report:
> >  'perf report --stdio -i perf-test.data' (3 runs)
> >   (perf-test.data size was around 12GB)
> >
> >   current code:
> >    446,826,474,217      cycles                     ( +-  0.23% )
> >    669,435,100,846      instructions               ( +-  0.03% )
> >
> >      266.380674551 seconds time elapsed            ( +-  0.37% )
> >
> >   change:
> >    558,345,509,819      cycles                     ( +-  0.55% )
> >    817,283,647,637      instructions               ( +-  0.03% )
> >
> >      351.564209617 seconds time elapsed            ( +-  0.89% )
> 
> message is confusing. Looks like time went up.

aaargh.. right ;-) it should bethe other way around

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/