linux-kernel - Re: [PATCH 4/4] tools lib traceevent: Added support for __get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140602224743.22c8cbb1@gandalf.local.home>
Date:	Mon, 2 Jun 2014 22:47:43 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...hat.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Javi Merino <javi.merino@....com>
Subject: Re: [PATCH 4/4] tools lib traceevent: Added support for
 __get_bitmask() macro

On Tue, 03 Jun 2014 11:43:26 +0900
Namhyung Kim <namhyung@...il.com> wrote:

> Hi Steve,
> 
> On Fri, 16 May 2014 10:02:19 -0400, Steven Rostedt wrote:
> > @@ -3691,6 +3784,23 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
> >  	case PRINT_BSTRING:
> >  		print_str_to_seq(s, format, len_arg, arg->string.string);
> >  		break;
> > +	case PRINT_BITMASK: {
> > +		int bitmask_offset;
> > +		int bitmask_size;
> > +
> > +		if (arg->bitmask.offset == -1) {
> > +			struct format_field *f;
> > +
> > +			f = pevent_find_any_field(event, arg->bitmask.bitmask);
> > +			arg->bitmask.offset = f->offset;
> > +		}
> > +		bitmask_offset = data2host4(pevent, data + arg->string.offset);
> 
> s/string.offset/bitmask.offset/

Duh, thanks!

-- Steve

> 
> Thanks,
> Namhyung
> 
> 
> > +		bitmask_size = bitmask_offset >> 16;
> > +		bitmask_offset &= 0xffff;
> > +		print_bitmask_to_seq(pevent, s, format, len_arg,
> > +				     data + bitmask_offset, bitmask_size);
> > +		break;
> > +	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/