linux-kernel - Re: [PATCH] i8042: Don't print an error message just because there's no chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN+gG=H3PRfwBXuNQmgjpSesJ7nHODRJ1=geDZ_+Fmw==6jHSg@mail.gmail.com>
Date:	Tue, 3 Jun 2014 10:00:22 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Adam Jackson <ajax@...hat.com>
Cc:	Josh Boyer <jwboyer@...oraproject.org>,
	linux-input <linux-input@...r.kernel.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Peter Jones <pjones@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] i8042: Don't print an error message just because there's
 no chip

On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson <ajax@...hat.com> wrote:
> On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote:
>> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@...hat.com> wrote:
>> > From: Peter Jones <pjones@...hat.com>
>> >
>> > Some systems, such as EFI-based Apple systems, won't necessarily have an
>> > i8042 to initialize. We shouldn't be printing an error message in this
>> > case, since not detecting the chip is the correct behavior.
>> >
>> > v2: Downgrade to pr_notice instead of pr_err.
>> >
>> > Signed-off-by: Adam Jackson <ajax@...hat.com>
>>
>> Reviewed-by:  Josh Boyer <jwboyer@...oraproject.org>
>
> Ping?  This patch or something like it has been pending since 2008 [1],
> would be nice to see it merged before it's old enough to start first
> grade.
>
> [1] - https://lkml.org/lkml/2008/9/29/248
>

Hey Ajax,

regarding the input stuff, adding the maintainers always help.
So adding Dmitry in CC.

BTW, the patch looks good enough:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/