linux-kernel - Re: [PATCH v5 00/15] Thunderbolt driver for Apple MacBooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140603203350.GC6582@kroah.com>
Date:	Tue, 3 Jun 2014 13:33:50 -0700
From:	Greg KH <greg@...ah.com>
To:	Andreas Noever <andreas.noever@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Subject: Re: [PATCH v5 00/15] Thunderbolt driver for Apple MacBooks

On Tue, Jun 03, 2014 at 10:03:57PM +0200, Andreas Noever wrote:
> Hi,
> 
> Updated version of the driver. Includes changes by Matthew to make it work on
> Falcon Ridge hardware (present in the newest Mac(Book)Pro). 
> 
> Changes since v4 (suggested by Matthew):
>  - Changed the PCI quirks to check just for Apple hardware instead of checking
>    against a list of machines. (The PCI id check already restricts this quirk
> to the relevant Apple machines).
>  - Added Falcon Ridge PCI id to the driver and to the "wait_for_thunderbolt"
>    quirk (the "poweroff_thunderbolt" quirk is no longer necessary for Falcon
> Ridge devices).
>  - Fixed plug events for Falcon Ridge hardware.
> 
> @Matthew: I think that your patch was missing the Falcon Ridge PCI id within
> the wait_for_thunderbolt quirk (I have added it). If you have time could you
> verify that suspend/resume works on your MacPro?  Thanks!
> 
> As before Matthew's ACPI changes (latest version: [1]) are required for this to
> work properly. Without them you need to boot with a coldplugged TB device to
> prevent the firmware from disabling the controller.

Looks good, I'll queue these up to my tree after 3.16-rc1 is out unless
anyone finds any problems with them before then.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/