| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <7ae844da4d9059d993c9527f59d35c74f47093fc.1401828520.git.himangi774@gmail.com> Date: Wed, 4 Jun 2014 02:53:54 +0530 From: Himangi Saraogi <himangi774@...il.com> To: Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Cc: julia.lawall@...6.fr Subject: [PATCH 1/2] usb: gadget: mv_u3d_core: Correct clk_disable twice There is a call to clk_disable a few lines before the goto err_alloc_ep_context. The clk goes not get enabled anywhere after that so this is not required. This patch fixes the bug by removing the deinit and clk_disable after the goto statement. Signed-off-by: Himangi Saraogi <himangi774@...il.com> --- drivers/usb/gadget/mv_u3d_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c index 1624871..c6db4a8 100644 --- a/drivers/usb/gadget/mv_u3d_core.c +++ b/drivers/usb/gadget/mv_u3d_core.c @@ -1980,9 +1980,6 @@ err_alloc_trb_pool: dma_free_coherent(&dev->dev, u3d->ep_context_size, u3d->ep_context, u3d->ep_context_dma); err_alloc_ep_context: - if (pdata->phy_deinit) - pdata->phy_deinit(u3d->phy_regs); - clk_disable(u3d->clk); err_u3d_enable: iounmap(u3d->cap_regs); err_map_cap_regs: -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists