linux-kernel - Re: [PATCH 01/21] irq: add devres version of OF IRQ mapping routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jun 2014 15:39:32 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Nikita Yushchenko <nyushchenko@....rtsoft.ru>
cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	lugovskoy@....rtsoft.ru
Subject: Re: [PATCH 01/21] irq: add devres version of OF IRQ mapping
 routines

On Wed, 4 Jun 2014, nyushchenko@....rtsoft.ru wrote:

> From: Nikita Yushchenko <nyushchenko@....rtsoft.ru>
> 
> Many drivers use devres to manage their resources, and at the same time
> use irq_of_parse_and_map() / irq_dispose_mapping(). This creates problem
> on driver unload paths and on error paths:
> - it is invalid to call irq_dispose_mapping() while IRQ handler is still
>   installed,
> - devres moves removal of IRQ handler out of driver,
> - without explicit devres support for IRQ mapping, irq_dispose_mapping()
>   stays in driver and thus gets called while IRQ handler is still
>   installed.
> 
> This patch adds devm_irq_create_of_mapping() and devm_irq_of_parse_and_map()
> routines to be used by drivers for correct release of resources.
> 
> Signed-off-by: Nikita Yushchenko <nyushchenko@....rtsoft.ru>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/