linux-kernel - Re: [PATCH] fence: Use smp_mb__before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140604174803.GB20812@kroah.com>
Date:	Wed, 4 Jun 2014 10:48:03 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sumit Semwal <sumit.semwal@...aro.org>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fence: Use smp_mb__before_atomic()

On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote:
> Hi Greg,
> 
> 
> On 30 May 2014 21:38, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote:
> >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote:
> >> > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote:
> >> > > From: Thierry Reding <treding@...dia.com>
> >> > >
> >> > > Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic())
> >> > > deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*()
> >> > > functions in favour of the unified smp_mb__{before,after}_atomic().
> >> > >
> >> > > Signed-off-by: Thierry Reding <treding@...dia.com>
> >> > > ---
> >> > >  drivers/base/fence.c | 4 ++--
> >> >
> >> > Where does this file come from?  I've not seen it before, and it's not
> >> > in my tree.
> >>
> >> I think it came in through Sumit's tree and it's only in linux-next I
> >> believe.
> >
> > Odd, linux-next is for merging things in Linus's next release.
> >
> > And as I have never seen this code that will end up being my
> > responsibility to maintain, it seems strange that it will be merged in
> > the next kernel development cycle.
> >
> > What broke down here with our review process that required something to
> > be merged without at least a cc: to me?
> 
> This is a new file added by Maarten's patches [1], that got reviewed
> on dri-devel and other mailing lists. Since it was quite closely
> associated with dma-buf, I figured I should take it through the
> dma-buf tree.
> 
> I am sorry I didn't notice that you weren't CC'ed on these patches -
> Sincere apologies, since I should've noticed that during the patch
> review process - I would take part of the blame here as well  :(
> 
> I do realize now that atleast on my part, I should've asked you before
> taking it through the dma-buf tree - I will make sure things like this
> don't happen again through me.
> 
> May I request you to help us handle this - would it help if we add
> Maarten as the maintainer for this file? Any other suggestions?

I'd prefer the fence.c file not be in the driver core at all for now as
it doesn't follow the rules for other files in that directory (symbol
exports, __functions that are global, config option for no good reason,
etc.)

Any chance you can just drop these and go through another review cycle?
I'm not sold on even why this file is needed at all, and that our
current kernel primitives don't work instead.

Doubly good reason is that you, or someone, is assuming that I was
going to maintain this...

So, care to drop the series and have Maarten resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/