linux-kernel - Re: [PATCH] ARM: fix debug prints relevant to PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2014 23:32:48 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Vidya Sagar <vidyas@...dia.com>, linux@....linux.org.uk,
	bhelgaas@...gle.com, wangyijing@...wei.com,
	thierry.reding@...il.com, jason@...edaemon.net,
	will.deacon@....com, swarren@...dia.com, kthota@...dia.com
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	sagar.tv@...il.com
Subject: Re: [PATCH] ARM: fix debug prints relevant to PCI devices

Hello.

On 06/04/2014 11:17 PM, Vidya Sagar wrote:

> As per PCIe spec, fast back-to-back transactions feature
> is not applicable to PCIe devices. Hence, do not print
> that fast back-to-back trasactions are disabled when
> there is a PCIe device found on the bus

> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
>   arch/arm/kernel/bios32.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)

> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> index 17a26c1..95ad3fb 100644
> --- a/arch/arm/kernel/bios32.c
> +++ b/arch/arm/kernel/bios32.c
[...]
> @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>
>   	/*
>   	 * Report what we did for this bus
> +	 * (only if the bus doesn't have even one PCIe device)
>   	 */
> -	printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
> -		bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> +	if (!has_pcie_dev)
> +		printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",

    Time to change this to pr_info()...

> +			bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
>   }
>   EXPORT_SYMBOL(pcibios_fixup_bus);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/