linux-kernel - Re: [PATCH] Documentation: accounting: getdelays.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+S6x-TjDYpooHMQyrLHuMYb0fHMH6H9ZiVCwEWm-Gw+w@mail.gmail.com>
Date:	Wed, 4 Jun 2014 14:39:32 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation: accounting: getdelays.c: Cleaning up
 missing null-terminate after strncpy call

On Wed, Jun 4, 2014 at 2:25 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  Documentation/accounting/getdelays.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index c6a06b7..f405780 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -314,6 +314,7 @@ int main(int argc, char *argv[])
>                         break;
>                 case 'm':
>                         strncpy(cpumask, optarg, sizeof(cpumask));
> +                       cpumask[sizeof(cpumask) - 1] = '\0';
>                         maskset = 1;
>                         printf("cpumask %s maskset %d\n", cpumask, maskset);
>                         break;
> --
> 1.7.10.4
>

Yup, looks right. Thanks for the patch! Luckily this is just example code. :)

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/