linux-kernel - Re: [PATCH] s390: scsi: zfcp_aux.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Jun 2014 00:22:13 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Steffen Maier <maier@...ux.vnet.ibm.com>, linux390@...ibm.com,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-s390@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390: scsi: zfcp_aux.c: Cleaning up missing
 null-terminate after strncpy call

Hi

A little embarrassing, but I actually did not know that there was a
better replacement for strncpy.

Sorry, but I will send a new platch based on strlcpy instead then.


Best regards
Rickard Strandqvist


2014-06-04 23:59 GMT+02:00 Heiko Carstens <heiko.carstens@...ibm.com>:
> On Wed, Jun 04, 2014 at 11:31:11PM +0200, Rickard Strandqvist wrote:
>> Added a guaranteed null-terminate after call to strncpy.
>>
>> This was partly found using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>  drivers/s390/scsi/zfcp_aux.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
>> index 8004b07..138b84a 100644
>> --- a/drivers/s390/scsi/zfcp_aux.c
>> +++ b/drivers/s390/scsi/zfcp_aux.c
>> @@ -102,6 +102,7 @@ static void __init zfcp_init_device_setup(char *devstr)
>>       if (!token || strlen(token) >= ZFCP_BUS_ID_SIZE)
>>               goto err_out;
>>       strncpy(busid, token, ZFCP_BUS_ID_SIZE);
>> +     busid[sizeof(busid) - 1] = '\0';
>
> Erm.. with
>         char busid[ZFCP_BUS_ID_SIZE];
> just a couple of lines above this seems to be rather pointless.
> However _if_ we change the code then replacing strncpy() with strlcpy()
> would be the way to go.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/