linux-kernel - Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140604231235.2269.qmail@ns.horizon.com>
Date:	4 Jun 2014 19:12:35 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	dborkman@...hat.com, linux@...izon.com
Cc:	akpm@...ux-foundation.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

>>> Perhaps a newline here.

>> Question: where do you think a newline should go?  It's not obvious
>> to me.  My style has been to keep as much of a declaration on one line
>> as possible so "git grep <function> include" is as informative as possible.

> It's just nit, but since you've asked, end result like this:
> 
> --snip--
> u32 crc32_le_shift(u32 crc, size_t len) __attribute_const__;
> 
> static inline u32 crc32_le_combine(u32 crc1, u32 crc2, size_t len2)
> {
> 	return crc32_le_shift(crc1, len2) ^ crc2;
> }
> --snap--

Ah, got it!  I couldn't figure out where it would make sense to insert
a newline into the middle of one line, breaking it into two.  Adding a
blank line makes sense, and makes your other comment make sense.

Good suggestion; I'll do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/