linux-kernel - Re: [PATCH v2] hsi: omap_ssi_port: use normal module refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Jun 2014 01:48:46 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Carlos Chinea <carlos.chinea@...ia.com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hsi: omap_ssi_port: use normal module refcounting

Hi,

On Wed, Jun 04, 2014 at 10:00:59AM +0200, Arnd Bergmann wrote:
> The ref_module() function is used for internal housekeeping of the
> module code, it's not normally used by subsystems or device drivers,
> and the use of ref_module in the omap_ssi_port driver causes a link
> build error when modules are disabled:
> 
> hsi/controllers/omap_ssi_port.c: In function 'ssi_port_probe':
> hsi/controllers/omap_ssi_port.c:1119:2: error: implicit declaration of function 'ref_module' [-Werror=implicit-function-declaration]
> 
> This changes the omap_ssi_port driver to use try_module_get()
> and module_put() instead, which is the normal way to ensure that
> the driver providing a device used in another module does not
> go away.

Thanks, applied:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=b357d7b58f379ebe8038cd97b6204f2f5c52220d

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)