linux-kernel - Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140604082240.GM1730@lahna.fi.intel.com>
Date:	Wed, 4 Jun 2014 11:22:40 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	eric.ernst@...ux.intel.com
Cc:	linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
	mark.gross@...el.com
Subject: Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to
 output

On Tue, Jun 03, 2014 at 03:25:16PM -0700, eric.ernst@...ux.intel.com wrote:
> From: Eric Ernst <eric.ernst@...ux.intel.com>
> 
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode.  When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
> 
> Signed-off-by: Eric Ernst <eric.ernst@...ux.intel.com>

Looks good now thanks,

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/