linux-kernel - Re: linux-next crash in xhci_add_ep_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Jun 2014 17:10:43 -0400
From:	Valdis.Kletnieks@...edu
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: linux-next crash in xhci_add_ep_to_interval

On Thu, 05 Jun 2014 12:05:56 -0700, Dan Williams said:

> Subject: usb: fix ->update_hub_device() vs hdev->maxchild
>
> From: Dan Williams <dan.j.williams@...el.com>
>
> Commit d8521afe3586 "usb: assign default peer ports for root hubs"
> delayed marking a hub valid (set hdev->maxchild) until it had been fully
> configured and to enable the publishing of valid hubs to be serialized
> by usb_port_peer_mutex.
>
> However, xhci_update_hub_device() in some cases depends on
> hdev->maxchild already being set.  Do the minimal fix and move it after
> the setting of hdev->maxchild.
>
> Cc: Mathias Nyman <mathias.nyman@...ux.intel.com>
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@...edu>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Applied cleanly, booted without complaint, the keyboard that's behind
the PS2-USB converter works.

uname -r reports 3.15.0-rc8-next-20140605-dirty as expected.

So feel free to stick a Tested-By: on there. :)

Content of type "application/pgp-signature" skipped