[<prev] [next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1406041712350.23521@chino.kir.corp.google.com>
Date: Wed, 4 Jun 2014 17:13:44 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
cc: Joonsoo Kim <iamjoonsoo.kim@....com>,
Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>,
Pekka Enberg <penberg@...nel.org>,
Christoph Lameter <cl@...ux.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, Joonsoo Kim <js1304@...il.com>,
Han Pingtian <hanpt@...ux.vnet.ibm.com>, paulus@...ba.org,
Anton Blanchard <anton@...ba.org>, mpm@...enic.com,
linuxppc-dev@...ts.ozlabs.org,
Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Subject: Re: [RESEND PATCH] slub: search partial list on numa_mem_id(),
instead of numa_node_id()
On Wed, 21 May 2014, Joonsoo Kim wrote:
> Currently, if allocation constraint to node is NUMA_NO_NODE, we search
> a partial slab on numa_node_id() node. This doesn't work properly on the
> system having memoryless node, since it can have no memory on that node and
> there must be no partial slab on that node.
>
> On that node, page allocation always fallback to numa_mem_id() first. So
> searching a partial slab on numa_node_id() in that case is proper solution
> for memoryless node case.
>
> Acked-by: Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>
> Acked-by: David Rientjes <rientjes@...gle.com>
> Acked-by: Christoph Lameter <cl@...ux.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 545a170..cc1f995 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1698,7 +1698,7 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node,
> struct kmem_cache_cpu *c)
> {
> void *object;
> - int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node;
> + int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node;
>
> object = get_partial_node(s, get_node(s, searchnode), c, flags);
> if (object || node != NUMA_NO_NODE)
Andrew, can you merge this please? It's still not in linux-next.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists