linux-kernel - Re: [RFC Patch 3/3] x86, irq: count legacy IRQs by legacy_pic->nr_legacy_irqs instead of NR_IRQS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1406051014490.23174@nanos>
Date:	Thu, 5 Jun 2014 10:15:29 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
cc:	"H. Peter Anvin" <hpa@...or.com>, Yinghai Lu <yinghai@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Michal Simek <monstr@...str.eu>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>, linux-pm@...r.kernel.org,
	xen-devel@...ts.xenproject.org, linux-pci@...r.kernel.org
Subject: Re: [RFC Patch 3/3] x86, irq: count legacy IRQs by legacy_pic->nr_legacy_irqs
 instead of NR_IRQS_LEGACY

On Thu, 5 Jun 2014, Jiang Liu wrote:

> Some platforms, such as Intel MID and mshypv, do not support legacy
> interrupt controllers. So count legacy IRQs by legacy_pic->nr_legacy_irqs
> instead of hard-coded NR_IRQS_LEGACY.

Nice patch set!
 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> ---
>  arch/x86/include/asm/i8259.h   |    2 ++
>  arch/x86/kernel/acpi/boot.c    |   13 ++++++------
>  arch/x86/kernel/apic/io_apic.c |   43 +++++++++++++++++++++++-----------------
>  arch/x86/kernel/devicetree.c   |   12 +++++------
>  arch/x86/kernel/irqinit.c      |    6 +++---
>  arch/x86/pci/xen.c             |    6 +++---
>  6 files changed, 46 insertions(+), 36 deletions(-)
> 
> diff --git a/arch/x86/include/asm/i8259.h b/arch/x86/include/asm/i8259.h
> index a20365953bf8..fdac75b8782a 100644
> --- a/arch/x86/include/asm/i8259.h
> +++ b/arch/x86/include/asm/i8259.h
> @@ -67,4 +67,6 @@ struct legacy_pic {
>  extern struct legacy_pic *legacy_pic;
>  extern struct legacy_pic null_legacy_pic;
>  
> +#define	nr_legacy_irqs()	(legacy_pic->nr_legacy_irqs)

That wants to be a static inline, please.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/