linux-kernel - Re: [PATCH] i2c: pca954x: Fix compilation without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140605131123.GA2837@katana>
Date:	Thu, 5 Jun 2014 15:11:23 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, khali@...ux-fr.org,
	linus.walleij@...aro.org, paul.gortmaker@...driver.com,
	jg1.han@...sung.com, Stephen Rothwell <sfr@...b.auug.org.au>,
	Jim Davis <jim.epost@...il.com>
Subject: Re: [PATCH] i2c: pca954x: Fix compilation without CONFIG_GPIOLIB

On Wed, Jun 04, 2014 at 06:56:32PM +0200, Laurent Pinchart wrote:
> The pca954x driver recently switched to the GPIO descriptor API without
> including the correct <linux/gpio/consumer.h> header. This breaks
> compilation without CONFIG_GPIOLIB.
> 
> drivers/i2c/muxes/i2c-mux-pca954x.c: In function ‘pca954x_probe’:
> drivers/i2c/muxes/i2c-mux-pca954x.c:204:2: error: implicit declaration
> of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
>   gpio = devm_gpiod_get(&client->dev, "reset");
>   ^
> drivers/i2c/muxes/i2c-mux-pca954x.c:204:7: warning: assignment makes
> pointer from integer without a cast [enabled by default]
>   gpio = devm_gpiod_get(&client->dev, "reset");
>        ^
> drivers/i2c/muxes/i2c-mux-pca954x.c:206:3: error: implicit declaration
> of function ‘gpiod_direction_output’
> [-Werror=implicit-function-declaration]
>    gpiod_direction_output(gpio, 0);
>    ^
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1
> 
> Fix it by including the right header.
> 
> Reported-by: Jim Davis <jim.epost@...il.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)