linux-kernel - Re: [PATCH 3.4 022/214] filter: prevent nla extensions to peek beyond the end of the message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+rthh_xdM-i7QiJ7QLayz+n42msL9nORV5mQh4qtJX66uXWWA@mail.gmail.com>
Date:	Thu, 5 Jun 2014 15:49:48 +0200
From:	Mathias Krause <minipli@...glemail.com>
To:	Luis Henriques <luis.henriques@...onical.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Daniel Borkmann <dborkman@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH 3.4 022/214] filter: prevent nla extensions to peek beyond
 the end of the message

On 5 June 2014 15:33, Luis Henriques <luis.henriques@...onical.com> wrote:
> On Wed, Jun 04, 2014 at 09:16:25PM -0700, Greg Kroah-Hartman wrote:
>> 3.4-stable review patch.  If anyone has any objections, please let me know.
>> [...]
>> --- a/net/core/filter.c
>> +++ b/net/core/filter.c
>> @@ -338,11 +338,15 @@ load_b:
>>
>>                       if (skb_is_nonlinear(skb))
>>                               return 0;
>> +                     if (skb->len < sizeof(struct nlattr))
>> +                             return 0;
>> +                     if (skb->len < sizeof(struct nlattr))
>> +                             return 0;
>
> There above code is duplicated this backport.  The same comment
> applies to the 3.2.y backport (I've added Ben to the CC list).
>

Good catch! The diff should look more like the the one in the
attachment. I guess patch(1) just failed here to find the right place
to apply the hunk to.

Thanks,
Mathias

View attachment "filter-prevent-nla-extensions-to-peek-beyond-the-end-of-the-message-v3.4.patch" of type "text/x-patch" (691 bytes)