linux-kernel - Re: [PATCH] usb: gadget: gadgetfs: correct dev state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jun 2014 17:15:02 +0200
From:	Marcus Nutzinger <marcus.nutzinger@...obroma-systems.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: gadgetfs: correct dev state

Hi Sergei,

On Jun 5, 2014, at 4:18 PM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:

>   Please also specify that commit's summary line in parens.

I'll resubmit the updated patch in a minute!

>> +	/* other endpoints were all decoupled from this device */
>> +	spin_lock_irq(&dev->lock);
>> +	dev->state = STATE_DEV_DISABLED;
>> +	spin_unlock_irq(&dev->lock);
> 
>   Not sure I understand why you need spinlock here... isn't the assignment atomic already?


Sure, an assignment might be atomic. However, following the policy of commit 7489d149
(USB: gadgetfs cleanups) all ep0 state changes shall be protected by spinlocks.

Thanks,
Marcus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/