linux-kernel - Re: [PATCH v5] pinctrl: to avoid duplicated calling enable_pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5390917D.4040607@wwwdotorg.org>
Date:	Thu, 05 Jun 2014 09:49:17 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	fwu@...vell.com, linus.walleij@...aro.org
CC:	tony@...mide.com, plagnioj@...osoft.com, kgene.kim@...sung.com,
	heiko@...ech.de, t.figa@...sung.com, thomas.abraham@...aro.org,
	srinivas.kandagatla@...il.com, maxime.coquelin@...com,
	patrice.chotard@...com, thierry.reding@...il.com,
	baohua@...nel.org, viresh.linux@...il.com, matt.porter@...aro.org,
	syin@...adcom.com, jg1.han@...sung.com, Rongjun.Ying@....com,
	Rong.Wang@....com, linux@...sktech.co.nz,
	yongjun_wei@...ndmicro.com.cn, laurent.navet@...il.com,
	linux-kernel@...r.kernel.org, swarren@...dia.com,
	cxie4@...vell.com, ylmao@...vell.com, njiang1@...vell.com,
	tianxf@...vell.com, fswu@...vell.com
Subject: Re: [PATCH v5] pinctrl: to avoid duplicated calling enable_pinmux_setting
 for a pin

On 06/05/2014 12:50 AM, fwu@...vell.com wrote:
> From: Fan Wu <fwu@...vell.com>
> 
> What the patch did:
> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of
>   calling pinctrl_select_state
> 2.Remove the HW disable operation in in pinmux_disable_setting function.
> 3.Remove the disable ops in struct pinmux_ops
> 4.Remove all the disable ops users in current code base.
...

The overall concept, plus the bcm2835, and Tegra driver parts,
Acked-by: Stephen Warren <swarren@...dia.com>

That said ...

> diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c

> -static void tegra_pinctrl_disable(struct pinctrl_dev *pctldev,
> -				  unsigned function, unsigned group)
> -{
> -	struct tegra_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
> -	const struct tegra_pingroup *g;
> -	u32 val;
> -
> -	g = &pmx->soc->groups[group];
> -
> -	if (WARN_ON(g->mux_reg < 0))
> -		return;
> -
> -	val = pmx_readl(pmx, g->mux_bank, g->mux_reg);
> -	val &= ~(0x3 << g->mux_bit);
> -	val |= g->func_safe << g->mux_bit;
> -	pmx_writel(pmx, val, g->mux_bank, g->mux_reg);

Those last 5 lines don't exist in the latest code, so this patch won't
apply cleanly. You probably want to rebase this on top of LinusW's
latest pinctrl development branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/